Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate to cosmos/gogoproto #13070

Merged
merged 22 commits into from
Sep 8, 2022
Merged

refactor: migrate to cosmos/gogoproto #13070

merged 22 commits into from
Sep 8, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 29, 2022 •
edited
Loading

Description

Closes: #10925

After this is merged, I'll tag cosmossdk.io/api and update all dependencies.
This will remove the indirect dependency of gogo/protobuf.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 29, 2022 12:31
@julienrbrt julienrbrt changed the title refactor: migrate to cosmos/gogoprotobuf refactor: migrate to cosmos/gogoproto Aug 29, 2022
@julienrbrt julienrbrt marked this pull request as draft August 29, 2022 12:41
tac0turtle
tac0turtle previously requested changes Aug 29, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should review the changes here https://github.com/cosmos/gogoproto/commits/master before merging this into mainline.

@julienrbrt julienrbrt marked this pull request as ready for review August 29, 2022 22:33
@github-actions github-actions bot added the C:Cosmovisor Issues and PR related to Cosmovisor label Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited
Loading

Codecov Report

Merging #13070 (cb9a8a3) into main (d9972c4) will increase coverage by 0.40%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13070      +/-   ##
==========================================
+ Coverage   53.64%   54.05%   +0.40%     
==========================================
  Files         647      655       +8     
  Lines       55199    56223    +1024     
==========================================
+ Hits        29612    30390     +778     
- Misses      23215    23401     +186     
- Partials     2372     2432      +60
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <ø> (ø)
baseapp/baseapp.go 77.93% <ø> (ø)
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (ø)
client/context.go 54.49% <ø> (ø)
client/grpc_query.go 15.38% <ø> (ø)
client/tx/aux_builder.go 84.17% <ø> (ø)
client/tx/tx.go 33.57% <ø> (ø)
... and 56 more

@julienrbrt julienrbrt marked this pull request as ready for review September 8, 2022 10:51
amaury1093
amaury1093 reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, however when I run the makefile commands using 0.9.0, it regenerates to gogo/protobuf. I guess that's why you put 0.10 in the makefile, and waiting for this PR to get merged before tagging 0.10?

If so, I can approve now

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@julienrbrt
Copy link
Member Author

Code lgtm, however when I run the makefile commands using 0.9.0, it regenerates to gogo/protobuf. I guess that's why you put 0.10 in the makefile, and waiting for this PR to get merged before tagging 0.10?

If so, I can approve now

Right, I have been generating them with:

# How to run manually:
docker build --pull --rm -f "contrib/devtools/Dockerfile" -t cosmossdk-proto:latest "contrib/devtools"
docker run --rm -v $(pwd):/workspace --workdir /workspace cosmossdk-proto sh ./scripts/protocgen.sh

Once this is merged, 0.10 will be tagged with the Dockerfile changes.

tac0turtle
tac0turtle reviewed Sep 8, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick glance im not sure we need to replace all instances of goo/proto with cosmos/gogoproto, right?

amaury1093
amaury1093 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but I can test once the docker image is tagged

@julienrbrt julienrbrt enabled auto-merge (squash) September 8, 2022 17:13
@julienrbrt julienrbrt merged commit 6d0ef15 into main Sep 8, 2022
@julienrbrt julienrbrt deleted the julien/gogoproto branch September 8, 2022 17:27
@julienrbrt julienrbrt mentioned this pull request Sep 8, 2022
Merged
19 tasks
@colin-axner colin-axner mentioned this pull request Nov 2, 2022
Closed
3 tasks
@julienrbrt julienrbrt mentioned this pull request Nov 20, 2022
Closed
4 tasks
@amaury1093 amaury1093 mentioned this pull request Dec 15, 2022
Merged
19 tasks
@bdeneux bdeneux mentioned this pull request Jan 16, 2023
Merged
@julienrbrt julienrbrt mentioned this pull request Feb 7, 2023
Closed
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
refactor: migrate to cosmos/gogoproto (cosmos#13070)
469126e
@tkxkd0159 tkxkd0159 mentioned this pull request Oct 31, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:Simulations C:Store C:x/auth C:x/authz C:x/bank C:x/capability C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/staking C:x/upgrade Type: ADR Type: Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename github.com/gogo/protobuf fork to github.com/cosmos/gogoproto
4 participants
@julienrbrt @alexanderbez @amaury1093 @tac0turtle